netdev
[Top] [All Lists]

Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload suppo

To: Michael Chan <mchan@xxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Wed, 26 Oct 2005 01:22:48 +0200
Cc: Ayaz Abdulla <AAbdulla@xxxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1130272203.6236.2.camel@rh4>
References: <DBFABB80F7FD3143A911F9E6CFD477B00BA5D790@hqemmail02.nvidia.com> <20051025215932.GA17794@electric-eye.fr.zoreil.com> <1130272203.6236.2.camel@rh4>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Michael Chan <mchan@xxxxxxxxxxxx> :
> On Tue, 2005-10-25 at 23:59 +0200, Francois Romieu wrote:
> 
> > 
> > drivers/net/bnx2.c::bnx2_start_xmit seems bogus.
> > 
> Please explain what did you mean by bogus?

When the CPU sets the entries of a multi-descriptor packet, the first
descriptor is marked read while the next ones are still unset.

If any of BNX2_L2CTX_TX_HOST_{BIDX/BSEQ} prevents the asic to read
beyond 'prod' (or b(yte)seq ?), the ordering does not matter. Right ?

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>