| To: | Ayaz Abdulla <aabdulla@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Mon, 24 Oct 2005 14:21:28 -0700 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <435D1047.2070401@nvidia.com> |
| References: | <432D7354.8000503@colorfullife.com> <43595C42.4080201@pobox.com> <435D1047.2070401@nvidia.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 24 Oct 2005 12:48:07 -0400
Ayaz Abdulla <aabdulla@xxxxxxxxxx> wrote:
> Jeff,
>
> I made the changes you requested. Here is the new patch.
>
> Thanks,
> Ayaz
>
> Signed-off-By: Ayaz Abdulla <aabdulla@xxxxxxxxxx>
>
There are really three patches in here.
1. Use netdev_priv (trivial)
2. scatter/gather support
3. TSO support
Why do you set the fragments up in reverse order? Going backwards is
usually slow on most code.
The kernel coding style is to use lower case in local variable names (Flags)
and structure elements (PacketBuffer, FlagLen).
--
Stephen Hemminger <shemminger@xxxxxxxx>
OSDL http://developer.osdl.org/~shemminger
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Ayaz Abdulla |
|---|---|
| Next by Date: | Re: Request for an ARPHRD_, Daniele Orlandi |
| Previous by Thread: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Jeff Garzik |
| Next by Thread: | RE: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Ayaz Abdulla |
| Indexes: | [Date] [Thread] [Top] [All Lists] |