Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Sep 29, 2005 at 04:59:56PM -0700, Suzanne Wood wrote:
> Sorry to be thinking on-line, but if you mean this:
> 
>   if (in_dev = rcu_dereference(dev->ip_ptr))
> 
> I think that's fine.

Close.  What I had in mind is

        rcu_read_lock();
        in_dev = dev->ip_ptr;
        if (in_dev) {
                in_dev = rcu_dereference(in_dev);
                atomic_inc(&in_dev->refcnt);
        }
        rcu_read_unlock();
        return in_dev;

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt