netdev
[Top] [All Lists]

Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections

To: herbert@xxxxxxxxxxxxxxxxxxx
Subject: Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections
From: Suzanne Wood <suzannew@xxxxxxxxxx>
Date: Thu, 29 Sep 2005 16:39:57 -0700 (PDT)
Cc: Robert.Olsson@xxxxxxxxxxx, davem@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, paulmck@xxxxxxxxxx, walpole@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
  > From suzannew Thu Sep 29 16:30:28 2005

  > > From: Herbert Xu 30 Sep 2005 07:28

  > > BTW, could you please move the rcu_dereference in in_dev_get()
  > > into the if clause? The barrier is not needed when ip_ptr is
  > > NULL.

  > The trouble with that may be that there are three events, the
  > dereference, the assignment, and the conditional test.  The
  > rcu_dereference() is meant to assure deferred destruction
  > throughout.

Sorry, I was thinking in terms of the rcu_read_lock, so this is misstated.

<Prev in Thread] Current Thread [Next in Thread>