netdev
[Top] [All Lists]

Re: [PATCH] Fix socket bitop damage

To: ralf@xxxxxxxxxxxxxx
Subject: Re: [PATCH] Fix socket bitop damage
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 23 Aug 2005 09:22:34 -0700 (PDT)
Cc: netdev@xxxxxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx
In-reply-to: <20050822110218.GA7514@linux-mips.org>
References: <20050822110218.GA7514@linux-mips.org>
Sender: netdev-bounce@xxxxxxxxxxx
From: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Date: Mon, 22 Aug 2005 12:02:18 +0100

> The socket flag cleanups that went into 2.6.12-rc1 are basically oring
> the flags of an old socket into the socket just being created.
> Unfortunately that one was just initialized by sock_init_data(), so already
> has SOCK_ZAPPED set.  As the result zapped sockets are created and all
> incoming connection will fail due to this bug which again was carefully
> replicated to at least AX.25, NET/ROM or ROSE.
> 
> In order to keep the abstraction alive I've introduced sock_copy_flags()
> to copy the socket flags from one sockets to another and used that
> instead of the bitwise copy thing.  Anyway, the idea here has probably
> been to copy all flags, so sock_copy_flags() should be the right thing.
> With this the ham radio protocols are usable again, so I hope this will
> make it into 2.6.13.
> 
> Signed-off-by: Ralf Baechle DL5RB <ralf@xxxxxxxxxxxxxx>

Applied, thanks Ralf.


<Prev in Thread] Current Thread [Next in Thread>