netdev
[Top] [All Lists]

Re: Strange uses of netif_start_queue

To: alan@xxxxxxxxxxxxxxxxxxx
Subject: Re: Strange uses of netif_start_queue
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 11:00:34 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <1123853714.22460.39.camel@localhost.localdomain>
References: <1123853714.22460.39.camel@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:35:14 +0100

> Something I noticed doing the tty work. the 6pack driver calls
> netif_start_queue() before it calls register_netdev. I'm curious if this
> is allowed ?

It's definitely a bug, and when register_netdev() happens it will
just overwrite that change of state.

Since the queue is not initialized yet, this could also cause
a crash or hang. :-)

<Prev in Thread] Current Thread [Next in Thread>