netdev
[Top] [All Lists]

Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

To: raghavendra.koushik@xxxxxxxxxxxx
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 12 Jul 2005 21:27:54 +0100
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, ravinandan.arakali@xxxxxxxxxxxx, leonid.grossman@xxxxxxxxxxxx, rapuru.sriram@xxxxxxxxxxxx
In-reply-to: <20050707222741.71C3E89826@linux.site>
References: <20050707222741.71C3E89826@linux.site>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
> 3. Enable two-buffer mode(for Rx path) automatically for SGI
>    systems. This improves Rx performance dramatically on 
>    SGI systems.

> +/* Enable 2 buffer mode by default for SGI system */
> +#ifdef CONFIG_IA64_SGI_SN2
> +#define CONFIG_2BUFF_MODE
> +#endif

this enabled it only on kernel that are built to only run on SN2
hardware, which is completely useless in practice.  Besides that defining
a CONFIG_ symbol from source files is a big no-go.

What exactly is the 2buff mode, and more specific what are the downsides
of  enabling it on non-SGI hardware?


<Prev in Thread] Current Thread [Next in Thread>