| To: | hch@xxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Tue, 12 Jul 2005 13:34:04 -0700 (PDT) |
| Cc: | raghavendra.koushik@xxxxxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, ravinandan.arakali@xxxxxxxxxxxx, leonid.grossman@xxxxxxxxxxxx, rapuru.sriram@xxxxxxxxxxxx |
| In-reply-to: | <20050712202754.GA10768@infradead.org> |
| References: | <20050707222741.71C3E89826@linux.site> <20050712202754.GA10768@infradead.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Christoph Hellwig <hch@xxxxxxxxxxxxx> Date: Tue, 12 Jul 2005 21:27:54 +0100 > > +/* Enable 2 buffer mode by default for SGI system */ > > +#ifdef CONFIG_IA64_SGI_SN2 > > +#define CONFIG_2BUFF_MODE > > +#endif > > this enabled it only on kernel that are built to only run on SN2 > hardware, which is completely useless in practice. Besides that defining > a CONFIG_ symbol from source files is a big no-go. Yes, do this in the Kconfig file instead. |
| Previous by Date: | Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements, Christoph Hellwig |
|---|---|
| Next by Date: | RE: [PATCH 2.6.12.1 5/12] S2io: Performance improvements, Leonid Grossman |
| Previous by Thread: | Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements, Christoph Hellwig |
| Next by Thread: | RE: [PATCH 2.6.12.1 5/12] S2io: Performance improvements, Ravinandan Arakali |
| Indexes: | [Date] [Thread] [Top] [All Lists] |