netdev
[Top] [All Lists]

Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

To: raghavendra.koushik@xxxxxxxxxxxx
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 07 Jul 2005 20:00:34 -0700 (PDT)
Cc: akepner@xxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, ravinandan.arakali@xxxxxxxxxxxx, leonid.grossman@xxxxxxxxxxxx, rapuru.sriram@xxxxxxxxxxxx
In-reply-to: <200507080106.j6816NKP022996@guinness.s2io.com>
References: <Pine.LNX.4.61.0507071552130.24321@resonance.WorkGroup> <200507080106.j6816NKP022996@guinness.s2io.com>
Sender: netdev-bounce@xxxxxxxxxxx
From: "Raghavendra Koushik" <raghavendra.koushik@xxxxxxxxxxxx>
Date: Thu, 7 Jul 2005 18:06:19 -0700

> wmb() is to ensure ordered PIO writes.

wmb() does no such thing.  It only has influence on
load and store instructions done by the local processor,
it has no effect on what the PCI bus may do with PIO
writes (ie. post them).

If you need a PIO to complete in a specific order, you
have to read it back.  If you need PIO operations to occur
in a specific order wrt. cpu memory operations, mmiowb()
is what you need to use.

<Prev in Thread] Current Thread [Next in Thread>