Re: [PATCH] loop unrolling in net/sched/sch_generic.c

[Thomas Graf <tgraf@xxxxxxx>]

* Eric Dumazet <42CA390C.9000801@xxxxxxxxxxxxx> 2005-07-05 09:38
> [NET] : unroll a small loop in pfifo_fast_dequeue(). Compiler generates 
> better code.
>       (Using skb_queue_empty() to test the queue is faster than trying to 
>       __skb_dequeue())
>       oprofile says this function uses now 0.29% instead of 1.22 %, on a 
>       x86_64 target.

I think this patch is pretty much pointless. __skb_dequeue() and
!skb_queue_empty() should produce almost the same code and as soon
as you disable profiling and debugging you'll see that the compiler
unrolls the loop itself if possible.