netdev
[Top] [All Lists]

Re: [PATCH] multipath routing algorithm, better patch

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH] multipath routing algorithm, better patch
From: Thomas Graf <tgraf@xxxxxxx>
Date: Fri, 1 Jul 2005 19:41:17 +0200
Cc: Patrick Jenkins <patjenk@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <42C4919A.5000009@trash.net>
References: <Pine.GSO.4.61.0506302014160.7400@rac1.wam.umd.edu> <42C4919A.5000009@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
* Patrick McHardy <42C4919A.5000009@xxxxxxxxx> 2005-07-01 02:43
> Multiple algorithms can be compiled in at once, so this patch is wrong.
> mp_alg is supplied by userspace:
> 
>         if (rta->rta_mp_alg) {
>                 mp_alg = *rta->rta_mp_alg;
> 
>                 if (mp_alg < IP_MP_ALG_NONE ||
>                     mp_alg > IP_MP_ALG_MAX)
>                         goto err_inval;
>         }
> 
> If it isn't set correctly its an iproute problem. Did you actually
> experience any problems?

Well, my patch for iproute2 to enable multipath algorithm selection
is currently being merged to Stephen together with the ematch bits.
We had to work out a dependency on GNU flex first (the berkley
version uses the same executable names) so the inclusion was
delayed a bit.

<Prev in Thread] Current Thread [Next in Thread>