| To: | juhl-lkml@xxxxxx |
|---|---|
| Subject: | Re: [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 15 Jun 2005 14:29:53 -0700 (PDT) |
| Cc: | yoshfuji@xxxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, ross.biro@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.62.0506152316060.3842@dragon.hyggekrogen.localhost> |
| References: | <Pine.LNX.4.62.0506152316060.3842@dragon.hyggekrogen.localhost> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Jesper Juhl <juhl-lkml@xxxxxx>
Date: Wed, 15 Jun 2005 23:32:22 +0200 (CEST)
> - if (length >= sizeof(*iph) && iph->ihl * 4 <= length) {
> + if (length >= sizeof(*iph) && (size_t)(iph->ihl * 4) <= length) {
Would changing the "4" into "4U" kill this warning just the same?
I think I'd prefer that.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c, Jesper Juhl |
|---|---|
| Next by Date: | Re: [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c, Jesper Juhl |
| Previous by Thread: | [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c, Jesper Juhl |
| Next by Thread: | Re: [-mm PATCH][4/4] net: signed vs unsigned cleanup in net/ipv4/raw.c, Jesper Juhl |
| Indexes: | [Date] [Thread] [Top] [All Lists] |