netdev
[Top] [All Lists]

Re: [-mm PATCH] signed vs unsigned cleanup in net/ipv4/raw.c

To: juhl-lkml@xxxxxx
Subject: Re: [-mm PATCH] signed vs unsigned cleanup in net/ipv4/raw.c
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2005 12:16:28 -0700 (PDT)
Cc: yoshfuji@xxxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, waltje@xxxxxxxxxxxxxxxxxxxxxxxxxxx, ross.biro@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.62.0506152101350.3842@dragon.hyggekrogen.localhost>
References: <Pine.LNX.4.62.0506152101350.3842@dragon.hyggekrogen.localhost>
Sender: netdev-bounce@xxxxxxxxxxx
I'm not merging this thing, at least no all at once.

"size_t" vs. "unsigned int" vs. "int" length comparisons are where all
the security problems come from in the protocol stack

Therefore you should make a seperate patch for each type
change you make and explain why it doesn't add some regression
in terms of signedness issues.

<Prev in Thread] Current Thread [Next in Thread>