| To: | linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [patch 2.6.12-rc6] b44: check link state during open |
| From: | "John W. Linville" <linville@xxxxxxxxxxxxx> |
| Date: | Wed, 8 Jun 2005 15:11:57 -0400 |
| Cc: | jgarzik@xxxxxxxxx |
| Mail-followup-to: | linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
Check the link state during b44_open. This closes a 1 HZ window
that existed after b44_open ran but before the b44_timer handler ran,
during which ethtool would report "Link detected: yes" no matter what
the link state actually was.
Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
---
drivers/net/b44.c | 3 +++
1 files changed, 3 insertions(+)
--- linux-2.6.12-rc6/drivers/net/b44.c.orig 2005-06-08 14:52:35.000000000
-0400
+++ linux-2.6.12-rc6/drivers/net/b44.c 2005-06-08 14:52:43.000000000 -0400
@@ -1285,6 +1285,9 @@ static int b44_open(struct net_device *d
b44_init_hw(bp);
bp->flags |= B44_FLAG_INIT_COMPLETE;
+ netif_carrier_off(dev);
+ b44_check_phy(bp);
+
spin_unlock_irq(&bp->lock);
init_timer(&bp->timer);
--
John W. Linville
linville@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: IPV6 RFC3542 compliance [PATCH], David Stevens |
|---|---|
| Next by Date: | Re: ipw2100: firmware problem, David S. Miller |
| Previous by Thread: | ipw2100: firmware problem, Pavel Machek |
| Next by Thread: | 2.6.12-rc6-mm1 OOPS in tcp_push_one(), Valdis . Kletnieks |
| Indexes: | [Date] [Thread] [Top] [All Lists] |