On Tuesday 31 May 2005 12:35 pm, Mitch Williams wrote:
> On Fri, 27 May 2005, jamal wrote:
> > On Fri, 2005-27-05 at 14:01 -0700, Stephen Hemminger wrote:
> > > Why not just allow adjusting dev->weight via sysfs?
> >
> > I think that should be good enough - and i thought your patch already
> > did this.
> > Adding a shift to the weight in a _weighted_ RR algorithm does sound
> > odd.
>
> Stephen's patch only affects the weight for the backlog device. Exporting
> dev-> weight to sysfs will allow the weight to be set for any network
> device. Which makes perfect sense.
>
> I'll work on getting this done and verifying performance this week.
> Expect a patch in a few days.
>
> Thanks, guys.
>
> -Mitch
It seems to me that the drivers should adjust dev->weight dependent on the
media speed/duplexity of the current link. A 10Mbps link will be constantly
re-enabling interrupts, as the incoming traffic is too slow. Why not have it
be 1/4 the weight of the gigabit NAPI weight, and set it when the link speed
is detected (or forced)?
Of course some performace analysis would have to be done to determine the
optimal numbers for each speed/duplexity setting per driver.
Thanks,
Jon
|