Re: [PATCH] r8169: support restricting speed+duplex in autonegotiation

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> :
[...]
> Is the "media" part of the patch confusing?

No (it could have stored its data in link_settings[] though).

I do not understand what the "ret" variable in rtl8169_set_speed_xmii()
is supposed to do but it is not a big issue.

Style aside, Ben has imho a point. The patch adds a special case:
- is there a real need ?
- is it a 8169-specific thing or not ?

The code is added in an area where the driver is currently not pretty.
The driver should probably replace its own defines with the ones in
<linux/mii.h> then really disable autonegotiation when it is asked to
(hint, hint).

--
Ueimor