netdev
[Top] [All Lists]

Re: [PATCH] baycom_epp.c: Fix compilation with gcc-4.1.0-20050522

To: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Subject: Re: [PATCH] baycom_epp.c: Fix compilation with gcc-4.1.0-20050522
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Fri, 27 May 2005 08:53:22 -0700
Cc: netdev@xxxxxxxxxxx, Thomas Sailer <t.sailer@xxxxxxxxxxxxxx>
In-reply-to: <200505271808.32032.adobriyan@gmail.com>
Organization: Open Source Development Lab
References: <200505271808.32032.adobriyan@gmail.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 27 May 2005 18:08:31 +0400
Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> drivers/net/hamradio/baycom_epp.c:432: error: jump into statement expression
>       ...
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> 
> --- linux-vanilla/drivers/net/hamradio/baycom_epp.c   2005-05-27 
> 12:58:48.000000000 +0400
> +++ linux-gcc4/drivers/net/hamradio/baycom_epp.c      2005-05-27 
> 17:54:14.000000000 +0400
> @@ -380,22 +380,18 @@ static inline void do_kiss_params(struct
>   */
>  
>  #define ENCODEITERA(j)                         \
> -({                                             \
>          if (!(notbitstream & (0x1f0 << j)))    \
>                  goto stuff##j;                 \
> -  encodeend##j:      ;                      \
> -})
> +  encodeend##j:      ;

Ick... Please just kill this kind of macro crap

<Prev in Thread] Current Thread [Next in Thread>