netdev
[Top] [All Lists]

Re: [PATCH 2.6.12-rc4] IPv4/IPv6: UDP Large Send Offload feature

To: ravinandan.arakali@xxxxxxxxxxxx
Subject: Re: [PATCH 2.6.12-rc4] IPv4/IPv6: UDP Large Send Offload feature
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 26 May 2005 16:42:17 -0700 (PDT)
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, raghavendra.koushik@xxxxxxxxxxxx, leonid.grossman@xxxxxxxxxxxx, ananda.raju@xxxxxxxxxxxx, rapuru.sriram@xxxxxxxxxxxx
In-reply-to: <20050526232006.60E6365005@linux.site>
References: <20050526232006.60E6365005@linux.site>
Sender: netdev-bounce@xxxxxxxxxxx
sock_append_data() seems like a lot of wasted work.

We already pass around the fragmented SKB as a list chained by
skb_shinfo(skb)->fraglist, just pass this thing to the device and in
this way you'll avoid all of that work sock_append_data() does
entirely.

Or is there a reason you did not implement it this
way?

This is one of the uses the skb_shinfo(skb)->fraglist was intended
for.

IN FACT, this fragmentation offload you are implementing here is what
the feature bit NETIF_F_FRAGLIST was meant to indicate.

<Prev in Thread] Current Thread [Next in Thread>