netdev
[Top] [All Lists]

Re: [XFRM] Call dst_check() with appropriate cookie

To: Kazunori Miyazawa <kazunori@xxxxxxxxxxxx>
Subject: Re: [XFRM] Call dst_check() with appropriate cookie
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 24 May 2005 18:34:19 +1000
Cc: YOSHIFUJI Hideaki / ???? <yoshfuji@xxxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4292E53D.7030805@miyazawa.org>
References: <E1DaTeW-00085B-00@gondolin.me.apana.org.au> <4292E53D.7030805@miyazawa.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, May 24, 2005 at 05:26:37PM +0900, Kazunori Miyazawa wrote:
> 
> Without our patch, the dst_check in xfrm_bundle_ok returns NULL
> when it is IPv6 route, then xfrm_bundle_ok always fails.
> xfrm_lookup calls xfrm_bundle_ok via stalbe_bundle so that
> it goes to restart and recreate bundles.
> But stale_bundle always fails. It results the infinite loop accordingly.

Yes this makes perfect sense.  However, I'd still like to know why I
have never seen it myself.  Let me double-check my test setup.

Anyway, I'm happy with the patch apart from the comments I gave elsewhere
in this thread.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>