netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] Implement NETDEV_FEAT_CHANGE

from [Stephen Hemminger] [Permanent Link][Original]
To: "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Implement NETDEV_FEAT_CHANGE
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 23 May 2005 09:33:29 -0700
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.62.0505201527250.26127@webhosting.rdsbv.ro>
Organization: Open Source Development Lab
References: <Pine.LNX.4.62.0505201527250.26127@webhosting.rdsbv.ro>
Sender: netdev-bounce@xxxxxxxxxxx 
> --- notify1/net/core/ethtool.c        2005-03-02 09:38:37.000000000 +0200
> +++ linux/net/core/ethtool.c  2005-05-23 11:30:47.000000000 +0300
...
> @@ -712,7 +715,6 @@ int dev_ethtool(struct ifreq *ifr)
>               break;
>       case ETHTOOL_GDRVINFO:
>               rc = ethtool_get_drvinfo(dev, useraddr);
> -
>               break;

White space creep

>       case ETHTOOL_GREGS:
>               rc = ethtool_get_regs(dev, useraddr);
> @@ -801,6 +803,10 @@ int dev_ethtool(struct ifreq *ifr)
>       
>       if(dev->ethtool_ops->complete)
>               dev->ethtool_ops->complete(dev);
> +
> +     if (old_features != dev->features)
> +             netdev_features_change(dev);
> +
>       return rc;
>  
>   ioctl:

Did you check for any  drivers that don't use ethtool_ops?
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: Why /sys/class/net/*/features is read-only?, Stephen Hemminger
Next by Date:  Re: [Netem] [PATCH] (3/3) netem: allow random reordering, Stephen Hemminger
Previous by Thread:  [PATCH] Implement NETDEV_FEAT_CHANGE, Catalin(ux aka Dino) BOIE
Next by Thread:  Re: [PATCH] Implement NETDEV_FEAT_CHANGE, Catalin(ux aka Dino) BOIE
Indexes:  [Date] [Thread] [Top] [All Lists]