| To: | "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming) |
| From: | Jon Mason <jdmason@xxxxxxxxxx> |
| Date: | Thu, 19 May 2005 11:06:53 -0500 |
| Cc: | netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.62.0505191654400.24043@webhosting.rdsbv.ro> |
| Organization: | IBM |
| References: | <Pine.LNX.4.62.0505191654400.24043@webhosting.rdsbv.ro> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | KMail/1.7.2 |
This patch only enables the features which are common between all of the bridged devices (at the time of their addition to the bridge). It overlooks the cases where not all of the adapters have the same features, or where the user has changed the enablement of a certain feature (via ethtool). Thanks, Jon On Thursday 19 May 2005 10:28 am, Catalin(ux aka Dino) BOIE wrote: > Hello! > > The attached patch, makes the bridge to select features (almost all) only > if _all_ devices supports them. > The patch was tested (create a bridge, add an interface, remove the > interface and always check features flags). > > What do you think? > > Signed-off-by: Catalin(ux aka Dino) BOIE <catab at umbrella.ro> > --- > Catalin(ux aka Dino) BOIE > catab at deuroconsult.ro > http://kernel.umbrella.ro/ |
| Previous by Date: | Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming), Nivedita Singhvi |
|---|---|
| Next by Date: | Re: Fw: 2.6.12-rc4-mm[12] - ULOG problem, Andrew Morton |
| Previous by Thread: | Re: [PATCH] [BRIDGE] Set features based on slave's ones, David S. Miller |
| Next by Thread: | Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming), Catalin(ux aka Dino) BOIE |
| Indexes: | [Date] [Thread] [Top] [All Lists] |