| To: | jdmason@xxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] [BRIDGE] Set features based on slave's ones |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 19 May 2005 11:53:53 -0700 (PDT) |
| Cc: | util@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <200505191106.53136.jdmason@us.ibm.com> |
| References: | <Pine.LNX.4.62.0505191654400.24043@webhosting.rdsbv.ro> <200505191106.53136.jdmason@us.ibm.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Jon Mason <jdmason@xxxxxxxxxx> Date: Thu, 19 May 2005 11:06:53 -0500 > This patch only enables the features which are common between all of the > bridged devices (at the time of their addition to the bridge). It overlooks > the cases where not all of the adapters have the same features, or where the > user has changed the enablement of a certain feature (via ethtool). There is not valid setting other than the subset of what the devices all support. Yes, the bridging code should listen for network device events when netdev->flag settings change, but otherwise this is the way to implement this. Just like bonding does. |
| Previous by Date: | Re: [PATCH] [BRIDGE] Set features based on slave's ones, David S. Miller |
|---|---|
| Next by Date: | Re: 2.6.12-rc4-mm[12] - ULOG problem, David S. Miller |
| Previous by Thread: | Re: [PATCH] [BRIDGE] Set features based on slave's ones, Jon Mason |
| Next by Thread: | Re: [PATCH] [BRIDGE] Set features based on slave's ones (was Ethernet Bridging: Enable Hardware Checksumming), Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |