Re: [PATCH] reduce stack usage for arlan

[Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx>]

On Sun, 15 May 2005 23:22:35 -0400, Jeff Garzik wrote:
> Jörn Engel wrote:
> >Jean Tourrilhes indicated that this driver is currently unmaintained.
> >Jeff, do you want this patch?
> 
> > #define SARLSTR(var,nn) {\
> >-    char tmpStr[400];\
> >+    char tmpStr[50];\
> >     int  tmpLn = nn;\
> >-    if (nn > 399 ) tmpLn = 399; \
> >+    BUG_ON(tmpLn > 49);\
> 
> I'm uncomfortable with arbitrarily lowering the string size, even if it 
> does include a BUG_ON()...

Here are all invocations of the macro in question:
        SARLSTR(textRegion, 48);
        SARLSTR(name, 16);

Still uncomfortable?

Jörn

-- 
Those who come seeking peace without a treaty are plotting.
-- Sun Tzu