netdev
[Top] [All Lists]

Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (

To: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>
Subject: Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (network) test on RHEL4 with kernel 2.6.12-rc1-mm4
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 17 May 2005 07:29:57 +1000
Cc: Andrew Morton <akpm@xxxxxxxx>, netdev@xxxxxxxxxxx, hejianj@xxxxxxxxxx, linuxppc64-dev@xxxxxxxxxxxxxxxxxxxxxxxxxx, anton@xxxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <5fc59ff3050516104367a8d5cd@mail.gmail.com>
References: <20050516025901.4b26ccf3.akpm@osdl.org> <E1DXdL8-0005mE-00@gondolin.me.apana.org.au> <5fc59ff3050516104367a8d5cd@mail.gmail.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Mon, May 16, 2005 at 10:43:02AM -0700, Ganesh Venkatesan wrote:
>
> @@ -1708,11 +1778,15 @@ err_rx_clean_list:
> 
>  static void e100_down(struct nic *nic)
>  {
> +#ifdef CONFIG_E100_NAPI
> +       /* wait here for poll to complete */
> +       netif_poll_disable(nic->netdev);
> +#endif

Sorry, you can't do that here since you're in softirq context and
netif_poll_disable may sleep.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>