| To: | herbert@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Sun, 15 May 2005 17:39:44 -0700 (PDT) |
| Cc: | johnpol@xxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050515235913.GA20242@gondor.apana.org.au> |
| References: | <20050515.152441.106262257.davem@davemloft.net> <20050515232020.GA19859@gondor.apana.org.au> <20050515235913.GA20242@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Date: Mon, 16 May 2005 09:59:13 +1000 > Actually that turns out to be OK since ip_ct_gather_frags zeros the > skb->sk field before feeding it to ip_defrag. Once the packet has > been reassembled it tries to put the sk back which fails unless the > head skb comes in last which is never the case on the output path. > > Although the second part is buggy, it does not violate the invariant > I stated before. This code should therefore just skb_orphan(), and nothing more. Right? |
| Previous by Date: | Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames, David S. Miller |
|---|---|
| Next by Date: | Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames, Herbert Xu |
| Previous by Thread: | Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames, David S. Miller |
| Next by Thread: | Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |