| To: | Tommy Christensen <tommy.christensen@xxxxxxxxx> |
|---|---|
| Subject: | Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122) |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Thu, 12 May 2005 09:17:51 +1000 |
| Cc: | Ken-ichirou MATSUZAWA <chamas@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx> |
| In-reply-to: | <4282846F.6070403@tpack.net> |
| References: | <20050510.214332.-1300551106.chamas@h4.dion.ne.jp> <20050510220751.GA459@gondor.apana.org.au> <20050511005836.GA1674@gondor.apana.org.au> <4282846F.6070403@tpack.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Thu, May 12, 2005 at 12:17:19AM +0200, Tommy Christensen wrote: > > What about an alternative fix, that avoids even more cloning (where > possible)? This resurrects the skb_orphan call that was moved out, last > time we had 'shared-skb troubles'. It is practically a no-op in the > common case, but still prevents the possible race with recvmsg. > (And I have a weakness for one-line-fixes). :-) BTW, we could also move the skb_orphan to the skb_get path since the cloned packets don't need the orphan call. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: [PATCH] netlink: defer socket destruction a bit, Herbert Xu |
|---|---|
| Next by Date: | 2.6.12-rc4-tcp2, Stephen Hemminger |
| Previous by Thread: | Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122), David S. Miller |
| Next by Thread: | Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122), Tommy Christensen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |