Re: [PATCH] netlink: defer socket destruction a bit

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, May 12, 2005 at 12:19:02AM +0200, Tommy Christensen wrote:
>
> diff -ru linux-2.6.12-rc4/net/netlink/af_netlink.c 
> linux-2.6.12-work/net/netlink/af_netlink.c
> --- linux-2.6.12-rc4/net/netlink/af_netlink.c 2005-05-11 11:10:20.000000000 
> +0200
> +++ linux-2.6.12-work/net/netlink/af_netlink.c        2005-05-12 
> 00:11:08.990990172 +0200
> @@ -785,11 +785,12 @@
>       sk_for_each_bound(sk, node, &nl_table[ssk->sk_protocol].mc_list)
>               do_one_broadcast(sk, &info);
>  
> +     kfree_skb(skb);
> +
>       netlink_unlock_table();
>  
>       if (info.skb2)
>               kfree_skb(info.skb2);
> -     kfree_skb(skb);

Good catch.  But doesn't this affect skb2 as well?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt