Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122)

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, May 12, 2005 at 12:17:19AM +0200, Tommy Christensen wrote:
> 
> I actually thought this was caused by another race. More on that later.

Please elaborate.
 
> What about an alternative fix, that avoids even more cloning (where
> possible)? This resurrects the skb_orphan call that was moved out, last
> time we had 'shared-skb troubles'. It is practically a no-op in the
> common case, but still prevents the possible race with recvmsg.
> (And I have a weakness for one-line-fixes). :-)

Yep this is much better.  Thanks Tommy.

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt