| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [1/7] [IPSEC] Add complete xfrm event notification |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sun, 8 May 2005 05:42:44 +1000 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxxxxx>, Masahide NAKAMURA <nakam@xxxxxxxxxxxxxx>, jamal <hadi@xxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <427CD5F5.9010605@trash.net> |
| References: | <1112702604.1089.119.camel@jzny.localdomain> <20050409105452.GA7171@gondor.apana.org.au> <20050507071434.GA5716@gondor.apana.org.au> <20050507071824.GA5753@gondor.apana.org.au> <427CD5F5.9010605@trash.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Sat, May 07, 2005 at 04:51:33PM +0200, Patrick McHardy wrote: > > This introduces a leak when xfrm_state_add()/xfrm_state_update() > fail. We hold two references (one from xfrm_state_alloc(), one > from xfrm_state_hold()), but only drop one. We need to take the > reference because the reference from xfrm_state_alloc() can > be dropped by __xfrm_state_delete(), so the fix is to drop both > references on error. Same problem in xfrm_user.c. Patch applied. Thanks for plugging the leaks :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [7/7] [IPSEC] Add XFRMA_SA/XFRMA_POLICY for delete notification, Herbert Xu |
|---|---|
| Next by Date: | Re: resend patch: xfrm policybyid, Herbert Xu |
| Previous by Thread: | Re: [1/7] [IPSEC] Add complete xfrm event notification, Patrick McHardy |
| Next by Thread: | [PATCH 1/1][ATM]: net/atm/ioctl.c: autoload pppoatm and br2684, chas williams - CONTRACTOR |
| Indexes: | [Date] [Thread] [Top] [All Lists] |