Re: resend patch: xfrm policybyid

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, May 05, 2005 at 09:14:36AM -0400, jamal wrote:
>
> +     if (policy->index)
> +             delpol = xfrm_policy_byid(dir, policy->index, 0);
> +     delpol2 = xfrm_policy_bysel(dir, &policy->selector, 0);
> +
> +     /* must be unique in both index and selector */
> +     if (delpol && delpol2) 
> +             if (delpol != delpol2) 
> +                     goto pol_err;
>  
> +     if (delpol) 
> +             delp = delpol;
> +     else 
> +             delp = delpol2;
> +                     
> +     if (delp && excl) { 
> +             ret = -EEXIST;
> +             goto pol_err;
> +     }
> +
> +     /* insert, sorted by prio*/
>       write_lock_bh(&xfrm_policy_lock);

This is still racy since delp can be killed by timers before you get
the lock.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt