netdev
[Top] [All Lists]

Re: [IPV4]: multipath_wrandom.c GPF fixes

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [IPV4]: multipath_wrandom.c GPF fixes
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 5 May 2005 14:28:00 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <427A828A.3080309@trash.net>
References: <427A828A.3080309@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 05 May 2005 22:31:06 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> multipath_wrandom needs to use GFP_ATOMIC.

I didn't fix this, because none of these allocations even
check the return value so it's kind of pointless.

There is zero error handling in the multipath modules.

But I suppose it's best to get some of this fixed rather
than none of it, so patch applied, thanks.

<Prev in Thread] Current Thread [Next in Thread>