On Thu, May 05, 2005 at 06:55:03PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> In article <42798AC1.2010308@xxxxxxxxxxx> (at Wed, 04 May 2005 19:53:53
> -0700), Mike Christie <michaelc@xxxxxxxxxxx> says:
>
> > +struct iscsi_uevent {
> :
> > +} __attribute__ ((aligned (sizeof(unsigned long))));
>
> I think it'd be better to use sizeof(uint64_t) or something.
Actually, it's completely unnecessary. iscsi_uevent contains a uint64_t
element, and the GCC docs (in the 'Type attribute' section, documenting
aligned) say:
Note that the alignment of any given `struct' or `union' type is
required by the ISO C standard to be at least a perfect multiple of
the lowest common multiple of the alignments of all of the members
of the `struct' or `union' in question. This means that you _can_
So best to just delete it. It has no effect.
> Please check other spots, too. e.g.:
>
> > + struct iscsi_stats_custom custom[0]
> > + __attribute__ ((aligned (sizeof(unsigned long))));
This one's probably useless too, but it's hard to tell since the patches
weren't sent inline thus making them difficult to cross-reference.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
|