| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: Question about QOS |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Tue, 3 May 2005 14:40:32 -0700 |
| Cc: | tgraf@xxxxxxx, nicolas.dichtel@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx |
| In-reply-to: | <427225B2.6010705@trash.net> |
| References: | <426E06F1.9000105@6wind.com> <20050426125955.GT577@postel.suug.ch> <426E56DC.7000108@6wind.com> <20050426191454.GU577@postel.suug.ch> <426F42F0.9020609@6wind.com> <20050427114216.GV577@postel.suug.ch> <427225B2.6010705@trash.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 29 Apr 2005 14:16:50 +0200 Patrick McHardy <kaber@xxxxxxxxx> wrote: > Thomas Graf wrote: > > * Nicolas DICHTEL <426F42F0.9020609@xxxxxxxxx> 2005-04-27 09:44 > > > >>>Yes I agree, it doesn't really matter what value we return and `bound' > >>>is most likely to be correct. I think we should also fix the unlikely > >>>but still possible case when tv1.tv_usec is slightly smaller than > >>>tv2.tv_usec. I know it is very unlikely but do_gettimeofday really > >>>is not that reliable and we have users which rely on a positive > >>>delta. Can you extend your patch to return abs(delta) for case 0 > >>>in PSCHED_TDIFF_SAFE? > > Why abs(delta)? It could be above bound, in fact all cases besides > delta_sec > 2 doesn't take care to stay inside [0..bound] at all. Applied, thanks Patrick. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RESEND] [PATCH 2.6.11.7] sch_htb: Drop packet when direct queue is full, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2.4 6/6][SCTP] Fix SCTP sendbuffer accouting., David S. Miller |
| Previous by Thread: | Re: [RESEND] [PATCH 2.6.11.7] sch_htb: Drop packet when direct queue is full, David S. Miller |
| Next by Thread: | Re: [PATCH 2.4 6/6][SCTP] Fix SCTP sendbuffer accouting., David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |