Re: [PATCH] net: Disable queueing when carrier is lost (take 2)

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, May 03, 2005 at 01:18:44PM +0200, Thomas Graf wrote:
> 
> I do like the patch, no question but IFF_RUNNING is still abused
> by drivers and some subsystems. So I'm not sure how reliable the
> above code will be without those cases fixed. I submitted a

Ouch, you're right.  They either need to be fixed or we'll just
have to go back to the simpler version that may call
dev_activate/dev_deactivate repeatedly.

> patchset once to fix some of them, not sure about the status. Also,
> what about those drivers that do not support or do not use
> netif_carrier_(on|off)?

They simply won't benefit from this patch.  This is OK since they're
no worse off than where they were before.  It might also prove to be
an incentive for someone to finally fix them :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt