netdev
[Top] [All Lists]

Re: patch: Action repeat

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: patch: Action repeat
From: Thomas Graf <tgraf@xxxxxxx>
Date: Mon, 2 May 2005 17:06:32 +0200
Cc: Patrick McHardy <kaber@xxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <1115035838.8929.236.camel@localhost.localdomain>
References: <4273BBAA.6060405@trash.net> <1114882045.8929.123.camel@localhost.localdomain> <4273CAB7.6080403@trash.net> <1114890709.8929.147.camel@localhost.localdomain> <20050430200848.GF577@postel.suug.ch> <1114894202.8929.165.camel@localhost.localdomain> <20050430215550.GH577@postel.suug.ch> <1114900485.8929.171.camel@localhost.localdomain> <20050430235809.GI577@postel.suug.ch> <1115035838.8929.236.camel@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1115035838.8929.236.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-02 08:10
> I would say that if dummy changes it because of a policy, then thats a
> fair deal. i.e
> 
> filter blah blah \
> action add meta classid global :23 

Absolutely, given it is requested by the user. My main concern are
dependencies on classid invisble to the user.

> I am beginning to think that perhaps classid should stay as a local
> scope metadata and what Patrick suggested maybe the way out. Although i
> have to admit I dont like a generic function to have a parameter that
> only a very small set of users find useful. If we are going to allow a
> structure to be passed back and forth, perhaps it should also carry
> other things (in addition to _result). Need to think a little.

What about if we introduce something like struct tcf_pkt_info as we
have it for ematches? I'm using it intensly to share information
from the classifier to ematches to extend and customize existing
classifier. We could declare tc_classid as being global by definition
and hide the current use in the API? I'd really like to be able to
transfer classification results from one device to another.

<Prev in Thread] Current Thread [Next in Thread>