netdev
[Top] [All Lists]

Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 2 May 2005 14:32:32 -0700
Cc: markb@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050502213220.GC16177@gondor.apana.org.au>
References: <E1DRFqC-00028H-Qi@tigger> <E1DRGWv-0003aa-00@gondolin.me.apana.org.au> <20050429093521.274adf9a.davem@davemloft.net> <20050429224931.GA18616@gondor.apana.org.au> <427623B8.8050107@wetlettuce.com> <20050502124358.7186447f.davem@davemloft.net> <20050502213220.GC16177@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 3 May 2005 07:32:20 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> However, AFAIK the tulip driver doesn't care about other interrupts.

Even the netdev watchdog?  :-)

tulip_tx_timeout takes the tp->lock.  Therefore it seems that Mark's
patch is correct _and_ needed, after all.

<Prev in Thread] Current Thread [Next in Thread>