netdev
[Top] [All Lists]

[PATCH] net/slip: replace schedule_timeout() with msleep_interruptible()

To: loz@xxxxxxxxxxxxxxxxxx, waltje@xxxxxxxxxxxxxxxxxxxxxxxxxxx
Subject: [PATCH] net/slip: replace schedule_timeout() with msleep_interruptible()
From: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Date: Sun, 1 May 2005 23:34:57 -0700
Cc: netdev@xxxxxxxxxxx, Kernel-Janitors <kernel-janitors@xxxxxxxxxxxxxx>
In-reply-to: <20050502061446.GB10173@us.ibm.com>
References: <20050502061446.GB10173@us.ibm.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
Use msleep_interruptible() instead of schedule_timeout() to guarantee
the task delays as expected.

--- 2.6.12-rc3/drivers/net/slip.c       2005-03-01 23:38:33.000000000 -0800
+++ 2.6.12-rc3-dev/drivers/net/slip.c   2005-05-01 20:53:08.000000000 -0700
@@ -1395,10 +1395,8 @@ static void __exit slip_exit(void)
        /* First of all: check for active disciplines and hangup them.
         */
        do {
-               if (busy) {
-                       set_current_state(TASK_INTERRUPTIBLE);
-                       schedule_timeout(HZ / 10);
-               }
+               if (busy)
+                       msleep_interruptible(100);
 
                busy = 0;
                for (i = 0; i < slip_maxdev; i++) {

<Prev in Thread] Current Thread [Next in Thread>