| To: | Tommy Christensen <tommy.christensen@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] net: Disable queueing when carrier is lost |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sat, 30 Apr 2005 10:46:38 +1000 |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050429234512.GA22699@gondor.apana.org.au> |
| References: | <E1DQlsn-0005yd-00@gondolin.me.apana.org.au> <426FDF8B.1030808@tpack.net> <20050427214224.GA25325@gondor.apana.org.au> <42701FFD.5000505@tpack.net> <20050427234359.GB22238@gondor.apana.org.au> <1114768308.4695.1487.camel@tsc-6.cph.tpack.net> <20050429101836.GA2237@gondor.apana.org.au> <1114777355.4695.1598.camel@tsc-6.cph.tpack.net> <20050429234512.GA22699@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
Hi Tommy: What if we take a more direct approach and just drop the packets before it hits hard_start_xmit? This also makes it easy for the drivers to do TX ring flushing if it's necessary since we're guaranteeing (for drivers that are not lockless anyway) that once carrier goes off while the xmit lock is held hard_start_xmit will not be called again. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Pktgen receive hook in dev.c?, jamal |
|---|---|
| Next by Date: | Re: patch2: del/get byid, Herbert Xu |
| Previous by Thread: | Re: [PATCH] net: Disable queueing when carrier is lost, Herbert Xu |
| Next by Thread: | Re: [PATCH] net: Disable queueing when carrier is lost, Tommy Christensen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |