netdev
[Top] [All Lists]

Re: patch2: del/get byid

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: patch2: del/get byid
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Apr 2005 12:25:49 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1114655014.7663.61.camel@localhost.localdomain>
References: <1114654284.7663.50.camel@localhost.localdomain> <20050428021426.GA23415@gondor.apana.org.au> <1114655014.7663.61.camel@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Wed, Apr 27, 2005 at 10:23:34PM -0400, jamal wrote:
> 
> well, i think it is a bug that indices are being ignored by the kernel.
> To demonstrate:
> Add a rule with index 100;
> now try to delete or get by index.

But your patch has nothing to do with this.  You were changing
id & 7 to dir.  Because the lower bits of index is set from the
direction, this is a no-op.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>