Re: [PATCH net-drivers-2.6 5/6] e100: Performance optimizations to e100 Tx Path

["Randy.Dunlap" <rddunlap@xxxxxxxx>]

On Thu, 21 Apr 2005 09:51:01 -0700 Ganesh Venkatesan wrote:

| 
| > |  static inline int e100_exec_cmd(struct nic *nic, u8 cmd, dma_addr_t 
dma_addr)
| > |  {
| > |       unsigned long flags;
| > | @@ -847,6 +847,10 @@ static inline int e100_exec_cb(struct ni
| > |                        * because the controller is too busy, so
| > |                        * let's just queue the command and try again
| > |                        * when another command is scheduled. */
| > | +                     if(err == -ENOSPC) {
| >                         if (err == -ENOSPC) {
| > is preferred (with space after if).
| > (same comment for below)
| 
| Is there a clear directive on 'if(' versus 'if ('? I see both styles
| being used. We are trying to stay consistent with 'if('.

There's nothing explicit in CodingStyle, but all of
the examples in CodingStyle use a space after 'if'.

And a few if's in this driver use a space after 'if',
but most don't iirc from counting them yesterday.

Thanks,
---
~Randy