Re: atomic_dec_and_test for child dst needed in dst_destroy?

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Apr 07, 2005 at 10:45:02PM -0700, Christoph Lameter wrote:
>
> +                     atomic_dec(&dst->__refcnt);
> +                     smp_mb__after_atomic_dec();
> +                     if (!atomic_read(&dst->__refcnt))
> +                             /*
> +                              * There are no other references and therefore
> +                              * the dst can be freed now
> +                              */
>                               goto again;

This is wrong.  The barrier needs to be after the atomic_read.
Please see my patch to Dave.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt