Re: atomic_dec_and_test for child dst needed in dst_destroy?

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Apr 07, 2005 at 03:30:28PM -0700, Christoph Lameter wrote:
> 
> So in case f.e. the refcnt was 2 for a child NOHASH entry, then we
> decrement the refcnt for the child but do not free it. However after
> dst_destroy the parent is gone and presumably some skb->dst are still
> pointing to the dst entry (or is there something else accounting for the
> remaining __refcnt)?
> 
> What happens to the child dst entry? Will the system simply never
> deallocate it?

If the refcnt is non-zero after the atomic_dec and the entry is NOHASH,
we return it and the caller will add it to the GC list.

See the relevant section in dst_run_gc and dst_free.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt