On Wed, Apr 06, 2005 at 02:37:21PM -0700, Dmitry Yusupov wrote:
>
> > In that case it's not enough to just use sk_allocation here.
> > You'll need a way to actually set it to GFP_ATOMIC.
>
> That's why in my patch I provided NETLINK_UESTABLISHED event. It is a
> right way and time to set sk->sk_allocation to GFP_ATOMIC for newly
> established netlink connection. imho.
Right. In that case I think you're going about this the wrong way.
It's unmanageable to have some external kernel module fiddle with
netlink's sk_allocation upon the receipt of a notification.
If you really want to do this, do it as a setsockopt. It's the owner
of the socket that wants the GFP_ATOMIC, not anybody else.
However, I'd like to know more about how open-iscsi uses this. In
particular, what are these messages and what do you do when the
GFP_ATOMIC alloc_skb fails?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|