| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: atomic_dec_and_test for child dst needed in dst_destroy? |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Tue, 5 Apr 2005 14:48:53 -0700 |
| Cc: | christoph@xxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <E1DIvr8-0002yy-00@gondolin.me.apana.org.au> |
| References: | <Pine.LNX.4.58.0504051155260.13697@server.graphe.net> <E1DIvr8-0002yy-00@gondolin.me.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 06 Apr 2005 07:45:06 +1000 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > When we are not the real parent of the dst (e.g., when we're xfrm_dst > and the child is an rtentry), it may already be on the GC list. > > In fact the current code is buggy to, we need to check dst->flags > before the dec as dst may no longer be valid afterwards. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Good catch Herbert, I'll apply this. |
| Previous by Date: | Re: atomic_dec_and_test for child dst needed in dst_destroy?, Herbert Xu |
|---|---|
| Next by Date: | Re: atomic_dec_and_test for child dst needed in dst_destroy?, Christoph Lameter |
| Previous by Thread: | Re: atomic_dec_and_test for child dst needed in dst_destroy?, Herbert Xu |
| Next by Thread: | Re: atomic_dec_and_test for child dst needed in dst_destroy?, Christoph Lameter |
| Indexes: | [Date] [Thread] [Top] [All Lists] |