| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 5 Apr 2005 20:39:18 +1000 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxxxxx>, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <42501E51.3000401@trash.net> |
| References: | <20050214221607.GC18465@gondor.apana.org.au> <424864CE.5060802@trash.net> <20050328233917.GB15369@gondor.apana.org.au> <424B40C2.90304@trash.net> <20050331004658.GA26395@gondor.apana.org.au> <20050331212325.5e996432.davem@davemloft.net> <20050402004956.GA24339@gondor.apana.org.au> <20050401172007.7296eced.davem@davemloft.net> <20050402020947.GA24998@gondor.apana.org.au> <42501E51.3000401@trash.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Sun, Apr 03, 2005 at 06:48:17PM +0200, Patrick McHardy wrote: > > Agreed. There is also a bug in my patch, tmpl->daddr can be 0 in which > case the daddr passed as an argument to xfrm_state_find() will be used. > My patch only checked tmpl->daddr, this patch fixes it. It also uses Why not just use daddr? It's always guaranteed to be correct. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] improvement on net/sched/cls_fw.c's hash function, Thomas Graf |
|---|---|
| Next by Date: | Re: Netlink Connector / CBUS, jamal |
| Previous by Thread: | Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel, Patrick McHardy |
| Next by Thread: | Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |