| To: | jamal <hadi@xxxxxxxxxx> |
|---|---|
| Subject: | Re: take 2-2 WAS(Re: PATCH: IPSEC xfrm events |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 5 Apr 2005 07:31:49 +1000 |
| Cc: | Patrick McHardy <kaber@xxxxxxxxx>, Masahide NAKAMURA <nakam@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <1112620614.1088.489.camel@jzny.localdomain> |
| References: | <1112406164.1088.54.camel@jzny.localdomain> <20050402014619.GB24861@gondor.apana.org.au> <1112469601.1088.173.camel@jzny.localdomain> <1112538718.1096.394.camel@jzny.localdomain> <20050404005805.GA16543@gondor.apana.org.au> <1112614706.1096.439.camel@jzny.localdomain> <20050404121641.GA12103@gondor.apana.org.au> <1112619096.1088.473.camel@jzny.localdomain> <20050404130224.GA12546@gondor.apana.org.au> <1112620614.1088.489.camel@jzny.localdomain> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Mon, Apr 04, 2005 at 09:16:55AM -0400, jamal wrote: > > Ok, fair enough. It annoys me too when i review patches ;-> > So i will fix this before final. Just one more thing, can you please remove the _bh's that you added to the read_lock for xfrm_km_list? It turns out that they're not necessary since the write_lock()'s are only held in process context. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: [PATCH] network configs: disconnect network options from drivers, Randy.Dunlap |
|---|---|
| Next by Date: | Re: [PATCH] network configs: disconnect network options from drivers, Sam Ravnborg |
| Previous by Thread: | Re: take 2-2 WAS(Re: PATCH: IPSEC xfrm events, jamal |
| Next by Thread: | Re: take 2-2 WAS(Re: PATCH: IPSEC xfrm events, jamal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |