On Mon, Apr 04, 2005 at 08:51:37AM -0400, jamal wrote:
>
> > > -static struct list_head xfrm_km_list = LIST_HEAD_INIT(xfrm_km_list);
> > > -static DEFINE_RWLOCK(xfrm_km_lock);
> >
> > How about letting these guys stay where they are? The move was
> > necessary before because the km_*_notify functions had to be called
> > in this file but that's no longer the case.
>
> Changed
> - dont see what the harm was as they were in that patch though.
Please see below.
> +static DEFINE_RWLOCK(xfrm_km_lock);
> +static struct list_head xfrm_km_list = LIST_HEAD_INIT(xfrm_km_list);
> EXPORT_SYMBOL(xfrm_replay_advance);
>
> -static struct list_head xfrm_km_list = LIST_HEAD_INIT(xfrm_km_list);
> -static DEFINE_RWLOCK(xfrm_km_lock);
All I wanted was to leave these lines as is so that they didn't
appear in the patch at all (except as conext) :)
When reviewing patches the most annoying thing is to see things
moved around or rearranged because that distracts the reviewer
from the substantiative changes.
> ;-> Yes, indeed. I think its time for you to throw in the towel ;->
Alright I give in :)
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|