Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Apr 01, 2005 at 05:20:07PM -0800, David S. Miller wrote:
> On Sat, 2 Apr 2005 10:49:56 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > The second patch creates a dead lock since it does a nested read
> > lock.  The solution is simply to get rid of xfrm_init_tempsel
> > and call the afinfo version directly.
> 
> read locks nest even in the presence of pending writers

Doh! I should've read the code first :)

It's still a valid clean-up patch though.

There is another reason why it won't dead lock.  We don't actually
ever hold the write lock on afinfo :) Is there any reason why we
dont't just use xfrm_state_afinfo_lock instead of afinfo->lock?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt