| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [IPSEC] Move xfrm_flush_bundles into xfrm_state GC |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Thu, 31 Mar 2005 21:21:38 -0800 |
| Cc: | kaber@xxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050328233032.GA15369@gondor.apana.org.au> |
| References: | <20050214221006.GA18415@gondor.apana.org.au> <20050214221200.GA18465@gondor.apana.org.au> <20050214221433.GB18465@gondor.apana.org.au> <20050214221607.GC18465@gondor.apana.org.au> <424864CE.5060802@trash.net> <20050328233032.GA15369@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 29 Mar 2005 09:30:32 +1000 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > The locking in xfrm_state/xfrm_policy has always struck me as being > an overkill. A lot of the locks should be replaced by rules that > ensure the validity of most operations while a ref count is held. > Now I have an excuse to do just that :) > > For 2.6.12 let's go for a simpler fix that breaks the dead lock. > > __xfrm_state_delete does not need to flush the bundles immediately. > In fact, it is more efficient if we delay the flush to the GC worker > since the flush is not dependent on any particular xfrm state. By > delaying it we can do one single flush even when you're deleteing > the entire xfrm state list. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Looks good, patch applied, thanks Herbert. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH][NET] make all protos partially use sk_prot, David S. Miller |
|---|---|
| Next by Date: | Re: Checking SPI in xfrm_state_find, David S. Miller |
| Previous by Thread: | Re: [IPSEC] Move xfrm_flush_bundles into xfrm_state GC, Patrick McHardy |
| Next by Thread: | Checking SPI in xfrm_state_find, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |