Re: RFC: Redirect-Device

[Stephen Hemminger <shemminger@xxxxxxxx>]

You need to cleanup the style.  
        Lots of dead commented out code.
        Encapsulating locking in macros is ugly and makes maintenance a 
nuisance.
       CamelCaps
        Use prdebug instead of DEBUG
        RCU instead of rwlock's or just use spinlock
        Adding new /proc interfaces is frowned on
        Adding new ioctl's are very frowned on
        global namespace issues with toupper et a..